[Editor] Hide the comment sidebar on document change #20220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the document changes the comment state from the old document should be replaced with that of the new document. To do this the comment manager is destroyed, but the corresponding comment sidebar wasn't destroyed yet, which resulted in the comment state from the old document still being visible for the new document. This commit fixes the issue by hiding the comment sidebar if the comment manager is destroyed. Note that hiding the comment sidebar effectively destroys all its state, and we already set the annotation mode to "none" on document change so we don't want to keep showing the comment sidebar anyway.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7f3ee0e1ab68a71/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7f3ee0e1ab68a71/output.txt Total script time: 0.95 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the document changes the comment state from the old document should be replaced with that of the new document. To do this the comment manager is destroyed, but the corresponding comment sidebar wasn't destroyed yet, which resulted in the comment state from the old document still being visible for the new document.
This commit fixes the issue by hiding the comment sidebar if the comment manager is destroyed. Note that hiding the comment sidebar effectively destroys all its state, and we already set the annotation mode to "none" on document change so we don't want to keep showing the comment sidebar anyway.
Fixes #20219.