Skip to content

[Editor] Fix the focus outline for the comment dialog buttons #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

[Editor] Fix the focus outline for the comment dialog buttons #20281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions web/comment_manager.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@
align-items: flex-start;
gap: 4px;

*:focus-visible {
outline: 2px solid var(--comment-focus-outline-color);
outline-offset: 0;
}

#commentManagerToolbar {
width: 100%;
height: 32px;
Expand Down
6 changes: 3 additions & 3 deletions web/viewer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,12 +792,12 @@
</div>
</dialog>

<dialog class="dialog commentManager" id="commentManagerDialog">
<dialog class="dialog commentManager" id="commentManagerDialog" aria-labelledby="commentManagerTitle">
<div class="mainContainer">
<div class="title" id="commentManagerToolbar">
<span id="commentManagerTitle" role="sectionhead" data-l10n-id="pdfjs-editor-edit-comment-dialog-title-when-adding" tabindex="0"></span>
<span id="commentManagerTitle" role="sectionhead" data-l10n-id="pdfjs-editor-edit-comment-dialog-title-when-adding"></span>
</div>
<textarea id="commentManagerTextInput" data-l10n-id="pdfjs-editor-edit-comment-dialog-text-input"></textarea>
<textarea id="commentManagerTextInput" data-l10n-id="pdfjs-editor-edit-comment-dialog-text-input" tabindex="0"></textarea>
<div class="dialogButtonsGroup">
<button id="commentManagerCancelButton" type="button" class="secondaryButton" tabindex="0">
<span data-l10n-id="pdfjs-editor-edit-comment-dialog-cancel-button"></span>
Expand Down