-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rotation causes textLayer to get messed up #3373
Conversation
/botio-windows preview |
1 similar comment
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/fd09eaea87a4d42/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/fd09eaea87a4d42/output.txt Total script time: 0.26 mins Published |
@@ -963,19 +963,24 @@ var CanvasGraphics = (function CanvasGraphicsClosure() { | |||
ctx.scale(-current.textHScale, 1); | |||
} | |||
}, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary change
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d38ae57262eede0/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d38ae57262eede0/output.txt Total script time: 0.26 mins Published |
ctx.stroke(); | ||
ctx.fill(); | ||
|
||
ctx.restore(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove extra spaces at the end
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/89afa0046d59ec0/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/89afa0046d59ec0/output.txt Total script time: 0.26 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f3e6ad13b57fdac/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/566b68365b6edd3/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/f3e6ad13b57fdac/output.txt Total script time: 23.93 mins
Image differences available at: http://107.21.233.14:8877/f3e6ad13b57fdac/reftest-analyzer.xhtml#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/566b68365b6edd3/output.txt Total script time: 30.76 mins
Image differences available at: http://107.22.172.223:8877/566b68365b6edd3/reftest-analyzer.xhtml#web=eq.log |
Looks like the path has to be reset at https://github.com/mozilla/pdf.js/blob/master/test/driver.js#L412 (since driver.js is reusing the same canvas) /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/186ff61fe1b35a9/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/db7c6013c05421c/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/db7c6013c05421c/output.txt Total script time: 23.63 mins
Image differences available at: http://107.21.233.14:8877/db7c6013c05421c/reftest-analyzer.xhtml#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/186ff61fe1b35a9/output.txt Total script time: 30.90 mins
Image differences available at: http://107.22.172.223:8877/186ff61fe1b35a9/reftest-analyzer.xhtml#web=eq.log |
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6b5fa919ec90a3d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a64ab8c8cee7309/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6b5fa919ec90a3d/output.txt Total script time: 22.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/a64ab8c8cee7309/output.txt Total script time: 27.36 mins
|
rotation causes textLayer to get messed up
Thank you for the patch |
No description provided.