Parse the date string into a proper date object in taar_dynamo. #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 60.16% 60.14% -0.03%
==========================================
Files 43 43
Lines 2119 2120 +1
==========================================
Hits 1275 1275
- Misses 844 845 +1
Continue to review full report at Codecov.
|
sunahsuh
approved these changes
Mar 6, 2018
harterrt
pushed a commit
that referenced
this pull request
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses the date option passed into taar_dynamo into a proper python datetime object.
I've tested this patch on atmo using
mozetl-submit.shpatched to point at crankycoder/python_mozetl instead of mozilla/python_mozetlr? @sunahsuh