This repository was archived by the owner on Nov 21, 2023. It is now read-only.
Bug 1347283 - Catch submission deserialization exceptions #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreid-moz
reviewed
Mar 15, 2017
| if field.name == 'submission': | ||
| payload = _parse_json(field.value_bytes[0].decode('utf-8')) | ||
| try: | ||
| payload = _parse_json(field.value_bytes[0].decode('utf-8')) |
There was a problem hiding this comment.
Should we also wrap the above call where we parse message.payload?
There was a problem hiding this comment.
We probably don't need to do this, since message.payload is only ever populated by something that is guaranteed to be (escaped) UTF8.
There was a problem hiding this comment.
It appears simply calling .decode('utf-8', 'ignore') may be the better solution. The test case to reproduce in the bug works and this would map more closely to what we're doing in scala.
whd
approved these changes
Mar 15, 2017
|
Closing in favor of #117. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to take care of errors like https://gist.github.com/maurodoglio/42bb80125ffc1003d5243cdd463936a3