Skip to content
This repository was archived by the owner on Nov 21, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion moztelemetry/heka/message_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def _parse_heka_record(record):
# because it contains null values for JSON fields that have been
# split out.
if field.name == 'submission':
payload = _parse_json(field.value_bytes[0].decode('utf-8'))
payload = _parse_json(field.value_bytes[0].decode('utf-8', 'replace'))
break

if payload is None:
Expand Down
23 changes: 23 additions & 0 deletions tests/data/test_invalid_utf8.heka

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions tests/heka/test_message_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,10 @@ def test_telemetry(data_dir):
for r in message_parser.parse_heka_message(o):
assert set(r.keys()) == top_keys
assert set(r["payload"].keys()) == payload_keys


def test_invalid_utf8(data_dir):
filename = "{}/test_invalid_utf8.heka".format(data_dir)
with open(filename, "rb") as o:
for r in message_parser.parse_heka_message(o):
assert(u'\ufffd' in r['info']['adapterDescription'])