This repository was archived by the owner on Nov 21, 2023. It is now read-only.
Bug 1376028 - Stop using Lazy json evaluation #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test that exposes the problem with lazy json evaluation.
mreid-moz
force-pushed
the
lazy_bug1376028
branch
from
987bb9b to
fcd8eb8
Compare
mreid-moz
force-pushed
the
lazy_bug1376028
branch
from
fcd8eb8 to
79f5197
Compare
|
@fbertsch flake8 is slain. ready for a look. |
|
@mreid-moz it took 1271s on the old code, and 842s on the new (without lazy parsing). I don't think this is going to have a significant effect, if any at all. |
fbertsch
approved these changes
Jun 28, 2017
|
What the heck? How can it be faster? Let's verify that we've actually fixed the issue you demonstrated in the notebook in the bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has potential performance implications. We should do some testing to see how it performs when we just parse all the json.