This repository was archived by the owner on Nov 21, 2023. It is now read-only.
Bug 1306049 - Sanitize string dimensions passed to "where" #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreid-moz
force-pushed
the
sanitize_bug1306049
branch
from
c11ef07 to
13351db
Compare
maurodoglio
suggested changes
Jun 28, 2017
moztelemetry/dataset.py
Outdated
| for name, path in self.selection_compiled.items()) | ||
|
|
||
| def _sanitize_dim(self, v): | ||
| """For String conditions, we should pre-sanitize so that users of |
There was a problem hiding this comment.
Could you format this docstring to follow the pep 257 conventions?
moztelemetry/dataset.py
Outdated
| :param v: a string value that should be sanitized. | ||
| """ | ||
| if v is not None: |
There was a problem hiding this comment.
I don't think this condition is needed
moztelemetry/dataset.py
Outdated
| raise Exception('The dimension {} doesn\'t exist'.format(dimension)) | ||
| if isfunction(condition) or isinstance(condition, functools.partial): | ||
| clauses[dimension] = condition | ||
| elif isinstance(condition, basestring): |
There was a problem hiding this comment.
The value that this condition is checked against is a string, so we can either raise an exception if this is not the case or convert condition to a string. I think the latter solution would make more sense but I don't have a strong opinion about it.
|
@maurodoglio RFAL |
mreid-moz
force-pushed
the
sanitize_bug1306049
branch
from
33e8d0f to
e0269b3
Compare
Hide the implementation details about how dimensions are sanitized for S3 storage. This way you can do things like: dataset.where(docType="saved-session") instead of having to know that the hyphen is replaced with an underscore when data is saved (and used "saved_session").
mreid-moz
force-pushed
the
sanitize_bug1306049
branch
from
e0269b3 to
d91bc60
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.