Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper import package instructions in the OSGi manifest #1163

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

makusuko
Copy link
Contributor

As Rhino now uses classes from javax-packages, add proper imports for them. Namely: javax.lang.model.SourceVersion and the various javax.script classes used for implementing the Java scripting support. This fixes the use of current Rhino version as an OSGi bundle.

@p-bakker p-bakker added the distribution Issues related to packaging up Rhino label Jan 24, 2022
@gbrail
Copy link
Collaborator

gbrail commented Jan 27, 2022

Thanks for staying on top of this!

@gbrail gbrail merged commit 743d21c into mozilla:master Jan 27, 2022
@p-bakker p-bakker added this to the Release 1.7.15 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distribution Issues related to packaging up Rhino
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants