Make getCharacterEncoding in UrlModuleSourceProvider protected #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows subclasses to override the encoding used in case a local javascript file is interpreted as being latin-1, when it should be whatever the file is encoded with. Before openJDK 17.0.3 this was automatically interpreted as utf-8.
|
Sorry we are so behind on these -- thanks for fixing this and it looks straighforward. Could you please add a test case to ensure that future changes don't break this? |
|
I could add a test, but I've only changed an access modifier. Do you want a test that uses reflection to confirm the access modifier is protected or public? A test that creates a subclass and confirms that the method can be overridden? I've added one using reflection. Let me know if you want something different. |
midgleyc
force-pushed
the
protected-encoding
branch
from
851e832
to
9540cff
Compare
|
I think that test is fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows subclasses to override the encoding used in case a local
javascript file is interpreted as being latin-1, when it should be
whatever the file is encoded with. Before openJDK 17.0.3 this was
automatically interpreted as utf-8.
Allows #1232 to be worked around by code calling Rhino.