Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup as follow up of pr 1284 #1285

Merged
merged 2 commits into from
Dec 2, 2022
Merged

cleanup as follow up of pr 1284 #1285

merged 2 commits into from
Dec 2, 2022

Commits on Dec 1, 2022

  1. make setFunctionProtoAndParent context aware, 

    deprecate the old versions
cleanup promise because the setup is now correct done by the ctor
    @rbri
    rbri committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    b0b643a View commit details
    Browse the repository at this point in the history

  2. A more flexible version of the FunctionObject.addAsConstructor(Script… 

    …able, Scriptable) method required at least for HtmlUnit to have better control of the attributes.

Looks like the right attributes today is only ScriptableObject.DONTENUM.
    @rbri
    rbri committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    03ff847 View commit details
    Browse the repository at this point in the history