355 function prototype apply argument array like #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrail
requested changes
Nov 10, 2017
| return obj != null && ( | ||
| obj instanceof NativeArray || | ||
| obj instanceof Arguments || | ||
| ScriptableObject.getProperty(obj, "length") != Scriptable.NOT_FOUND |
There was a problem hiding this comment.
Can we use "hasProperty" here instead? It could actually make a performance difference.
|
Thanks! That looks great. Now can you please squash this into one commit (right now there are 10)? Then I can take it from there and rebase and merge or whatever we need. |
tmallery
force-pushed
the
355_FunctionPrototypeApplyArgumentArrayLike
branch
from
acd9102
to
6bb9605
Compare
…unction.prototype.apply
tmallery
force-pushed
the
355_FunctionPrototypeApplyArgumentArrayLike
branch
from
b64825e
to
9779611
Compare
|
Thanks for the review and I believe I've finally squashed the changes into one commit. Local 'check' checks out. |
gbrail
approved these changes
Dec 1, 2017
|
Thanks -- looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#355
This fix matches ECMA5 behavior where an object passed in to apply as the second argument allows the call to proceed without exception.