Improvements to MemberBox #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrail
reviewed
May 15, 2018
| transient Class<?>[] argTypes; | ||
| transient Object delegateTo; | ||
| transient boolean vararg; | ||
| private transient Executable memberObject; |
There was a problem hiding this comment.
Can we make this final? I'm asking because some of the blogs talk about JVM optimizations for reflection (and MethodHandles, which we don't use yet) that only happen when they're final.
There was a problem hiding this comment.
Unfortunately, it can't be both transient and final as then it couldn't be assigned upon deserialization.
|
Of course -- thanks. I often wish that Rhino didn't have serialization. But it does, so we need to leave it like this. |
|
OK -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429 by allowing serialization of
MemberBox.delegateTo.It also adds some more improvements enabled by the fact that in modern Java, we now have
java.lang.reflect.Executableas a unifying type for bothMethodandConstructor. Using it reduces the need to typecheck and cast and it also allows unified access to parameter types and vararg flag, so they no longer need to be duplicated in theMemberBox.