fixes for #437 and #449 #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changing the line separator is not really related to this issue but the old impl hurts me every time i regenerate id classes on my win machine. The git checkout seems to translate the line separator; i think we have to reflect this in this tool also |
|
Hi Greg, |
|
I’ve been travelling a bit. Tomorrow!
…On Wed, Aug 1, 2018 at 7:34 AM RBRi ***@***.***> wrote:
Hi Greg,
any hope for this one?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#464 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAf0a7auUdEPaKz23L-hneEt2RZi6UGsks5uMZI8gaJpZM4VXh6D>
.
|
|
Ah, enjoy you trip. |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be fixed now, have not added many more unit tests but org.mozilla.javascript.tests.harmony.TypedArraysTest already includes tests for the isView function already.
Side note: the call in the issue is 'invalid'; the isView function is a static one. Calling isView on an object returns undefined (checked with ff)