Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array fixes #467

Merged
merged 6 commits into from
Aug 8, 2018
Merged

Array fixes #467

merged 6 commits into from
Aug 8, 2018

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Aug 5, 2018

some more fixes for our array implementations

@gbrail
Copy link
Collaborator

gbrail commented Aug 7, 2018

Thanks -- I like to see it when more tests are passing!

Do you think that any non-Rhino code would be depending on the signature of "getIndexIds"? I've never seen it but I thought I'd ask.

Finally, can you squash these commits? Otherwise I can do it.

@rbri
Copy link
Collaborator Author

rbri commented Aug 8, 2018

Thanks -- I like to see it when more tests are passing!

Same here, but there is still a lot of things to do.

Do you think that any non-Rhino code would be depending on the signature of "getIndexIds"? I've never seen it but I thought I'd ask.

Good question and i was sure you will ask this while changing this code. As always i have no idea. This is definitive a breaking change and we have to document it. But all the places using this method internally are fine with this change because they are using foreach. So i have pressed the submit button....
Maybe you can have a look at the history, might be the method is relatively new and added for a special need.
Or simply leave this commit out - i do not need this change.

Finally, can you squash these commits? Otherwise I can do it.

Last time i have tried squashing was a disaster. So please do it. But i learned in between how i can squash before making the push request - there is hope for the future :-)

@gbrail gbrail merged commit a5d9553 into mozilla:master Aug 8, 2018
@rbri rbri deleted the array_fixes branch April 26, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants