Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unnecssary synchronized issue for NativeJavaPackage.getPkgProperty: #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/org/mozilla/javascript/NativeJavaPackage.java
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,22 @@ NativeJavaPackage forcePackage(String name, Scriptable scope)
return pkg;
}

synchronized Object getPkgProperty(String name, Scriptable start,
Object getPkgProperty(String name, Scriptable start,
boolean createPkg)
{
Object cached = super.get(name, start);
if (cached != NOT_FOUND)
return cached;
return createPkgProperty(name, start, createPkg);
}

private synchronized Object createPkgProperty(String name, Scriptable start,
boolean createPkg)
{
if (negativeCache != null && negativeCache.contains(name)) {
// Performance optimization: see bug 421071
return null;
}

String className = (packageName.length() == 0)
? name : packageName + '.' + name;
Context cx = Context.getContext();
Expand Down