-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove serialization. #727
base: master
Are you sure you want to change the base?
Conversation
Get rid of every class that implements "Serializable" and associated machinery for readObject/writeObject and the like. Get rid of tests that assume it's there (not very many of those actually). Remove the "serialize" and "deserialize" commands from the shell. Remove SerializableInputStream and SerializableOutputStream.
@rbri and others who are regularly running the latest Rhino -- any chance you can try this and see if it causes big problems? It removes some classes and support that were previously supported although I think that they were generally not used. |
@gbrail did a first quick test with you PR applied to the HtmlUnit branch. Looks correct so far - no regressions. I only had failing tests because HtmlUnit supports serialization of dom objects (Scriptables). This was expected and is something i have to solve inside HtmlUnit. |
As this is a major change, maybe we can announce the plan and doing the next release without this. Then we will merge this directly after the release to have this for some time in the snapshots. |
Yes, I was thinking that it would be something for 1.8.0. And if it's
really useful, we can work on a better way to do it -- but, for instance, I
noticed that when you serialize an object it just keeps going and going
until you are doing things like serializing the internal state of the
interpreter, and I'm not sure that doing that really makes a lot of sense.
Perhaps we can come up with a better way to serialize objects that supports
your use case but doesn't serialize a bunch of stuff that I imagine you
can't use.
…On Mon, Jun 29, 2020 at 12:06 PM RBRi ***@***.***> wrote:
As this is a major change, maybe we can announce the plan and doing the
next release without this. Then we will merge this directly after the
release to have this for some time in the snapshots.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#727 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7I25ACBITZ3FVSJBXSXTRZDQ2PANCNFSM4OHPHF2A>
.
|
See #704 (comment) from linked issue. It mentions that serialization is currently being used with continuations. |
Hi Folks. What is the goal/benefit of remove serialization support? |
Converted to draft, as has conflicts and open discussions |
Get rid of every class that implements "Serializable" and associated
machinery for readObject/writeObject and the like. Get rid of tests
that assume it's there (not very many of those actually).
Remove the "serialize" and "deserialize" commands from the shell.
Remove SerializableInputStream and SerializableOutputStream.
Closes #704