Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AutoGrow for NativeJavaList / fix NPE in NativeJavaList/Map #889

Merged
merged 3 commits into from
May 11, 2021
Merged

Add AutoGrow for NativeJavaList / fix NPE in NativeJavaList/Map #889

merged 3 commits into from
May 11, 2021

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented May 10, 2021

This PR contains 2 code changes which should be unproblematic

  1. When a List/Map contains null values there was an NPE on cx.getWrapFactory().wrap(cx, this, obj, obj.getClass()); See: 0849085
  2. Support for auto grow, so that you can set values in a java.util.List. See cf84dbf

The rest are spotless fixes

@gbrail
Copy link
Collaborator

gbrail commented May 11, 2021

Those changes look very good and coverage is fine for the new stuff. Thanks!

@gbrail gbrail merged commit 423e738 into mozilla:master May 11, 2021
@p-bakker p-bakker added the Java Interop Issues related to the interaction between Java and JavaScript label Oct 13, 2021
@p-bakker p-bakker added this to the Release 1.7.14 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Java Interop Issues related to the interaction between Java and JavaScript
Projects
None yet
Milestone
Release 1.7.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rPraml @gbrail @p-bakker