Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "miscellaneous language-construct benchmarks" out of core::mem #13642

Closed
aochagavia opened this issue Apr 20, 2014 · 3 comments
Closed

Move "miscellaneous language-construct benchmarks" out of core::mem #13642

aochagavia opened this issue Apr 20, 2014 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@aochagavia
Copy link
Contributor

In std::mem there are some benchmarks regarding to miscellaneous language constructs (such as pattern matching and method dispatch). Since they have nothing to do with memory and the functions defined in this file, I think they should be moved to another place.

I thought it was reasonable to move them to src/test/bench, but it looks like this is not very convenient (see #13553 (comment)).
@aochagavia aochagavia mentioned this issue Apr 20, 2014
Merged
bors added a commit that referenced this issue Apr 20, 2014
@bors
auto merge of #13643 : aochagavia/rust/pr-2, r=alexcrichton
4d49693 
Fixed a typo in the documentation of std::mem, and refactored a function to use match instead of if.

Also added a FIXME to the benchmarks at the end of the file stating that they should be moved to another place, because they have nothing to do with `mem` (see #13642)
@aochagavia aochagavia changed the title Move "miscellaneous language-construct benchmarks" out from std::mem Move "miscellaneous language-construct benchmarks" out of std::mem May 12, 2014
@aochagavia
Copy link
Contributor Author

This has alredy been done

@oli-obk oli-obk mentioned this issue Sep 6, 2017
Open
nivkner added a commit to nivkner/rust that referenced this issue Sep 30, 2017
@nivkner
address some FIXMEs whose associated issues were marked as closed
ff99111 
remove FIXME(rust-lang#13101) since `assert_receiver_is_total_eq` stays.
remove FIXME(rust-lang#19649) now that stability markers render.
remove FIXME(rust-lang#13642) now the benchmarks were moved.
remove FIXME(rust-lang#6220) now that floating points can be formatted.
remove FIXME(rust-lang#18248) and write tests for `Rc<str>` and `Rc<[u8]>`
remove reference to irelevent issues in FIXME(rust-lang#1697, rust-lang#2178...)
update FIXME(rust-lang#5516) to point to getopts issue 7
update FIXME(rust-lang#7771) to point to RFC 628
update FIXME(rust-lang#19839) to point to issue 26925
@dtolnay dtolnay changed the title Move "miscellaneous language-construct benchmarks" out of std::mem Move "miscellaneous language-construct benchmarks" out of core::mem Oct 3, 2017
@dtolnay dtolnay reopened this Oct 3, 2017
@dtolnay
Copy link
Member

dtolnay commented Oct 3, 2017

Reopening because I don't think this was ever finished. The benchmarks were moved from std to core and from src to benches, but as of Rust 1.20 they are in libcore/benches/mem.rs which is still confusing because as commented above, they have nothing to do with memory or the functions in core::mem.

@dtolnay dtolnay mentioned this issue Oct 3, 2017
Merged
@pietroalbini pietroalbini added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 21, 2018
@Mark-Simulacrum
Copy link
Member

It looks like #44943 did indeed move the benchmarks out of libcore (and into librustc), so closing this.

Manishearth pushed a commit to Manishearth/rust that referenced this issue Nov 23, 2022
@bors
Auto merge of rust-lang#13642 - bvanjoi:fix-13292, r=Veykril
8050fdb 
fix(assists): remove `item_const` which had default value when implement missing members

Fixed rust-lang/rust-analyzer#13292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dtolnay @pietroalbini @Mark-Simulacrum @aochagavia