Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Refactor results in a single sortable array & display in basic table (changes .scan()) #59

Merged
merged 8 commits into from
Mar 14, 2014

Conversation

pauljt
Copy link

@pauljt pauljt commented Mar 14, 2014

This is the first part of issue #33. Instead of using an object containing arrays keyed by file name, all results are now one big array, with the details in each result itself (we actually had all this information duplicated). Since this obviously breaks the display table, I had to change the way we display results. The result is pretty minimal, but it just needs a nice CSS file to clean it up (I deliberately left this out so we can do #13 seperately)

The next part is to implement some kind of sorting - i tried ngGrid but it was buggy and fought with out existing css, so I'll probably just roll my own using array sorting.

PS @mozfreddyb I changed ng-mouseover to ngclick since mouseover does indeed suck currently #48
Note: This changes what ScanJS.scan returns! This will break tests as they currently work.

@pauljt
Copy link
Author

pauljt commented Mar 14, 2014

You can test this new UI here: http://people.mozilla.org/~ptheriault/scanjs/client/

@mozfreddyb
Copy link

We can make this sortable with angularjs really easy: http://docs.angularjs.org/api/ng/filter/orderBy

@pauljt
Copy link
Author

pauljt commented Mar 14, 2014

@mozfreddyb nice find! Added to patch

@mozfreddyb
Copy link

Fixed, Reviewed & Merging now :)

mozfreddyb added a commit that referenced this pull request Mar 14, 2014
Refactor results in a single sortable array & display in basic table (changes .scan())
@mozfreddyb mozfreddyb merged commit 15a0d5b into master Mar 14, 2014
@mozfreddyb mozfreddyb mentioned this pull request Mar 14, 2014
@mozfreddyb mozfreddyb deleted the sortable branch March 16, 2014 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants