This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Refactor results in a single sortable array & display in basic table (changes .scan()) #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of issue #33. Instead of using an object containing arrays keyed by file name, all results are now one big array, with the details in each result itself (we actually had all this information duplicated). Since this obviously breaks the display table, I had to change the way we display results. The result is pretty minimal, but it just needs a nice CSS file to clean it up (I deliberately left this out so we can do #13 seperately)
The next part is to implement some kind of sorting - i tried ngGrid but it was buggy and fought with out existing css, so I'll probably just roll my own using array sorting.
PS @mozfreddyb I changed ng-mouseover to ngclick since mouseover does indeed suck currently #48
Note: This changes what ScanJS.scan returns! This will break tests as they currently work.