Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up parsing #135

Merged
merged 2 commits into from Oct 1, 2014
Merged

Speed up parsing #135

merged 2 commits into from Oct 1, 2014

Conversation

@fitzgen
Copy link
Contributor

@fitzgen fitzgen commented Oct 1, 2014

These two changes together shave off about a quarter of time spent parsing the mappings property of a source map.

r? @past

@sokra
Copy link
Contributor

@sokra sokra commented Oct 1, 2014

👍

// Original name.
temp = base64VLQ.decode(str);
base64VLQ.decode(str, temp);

This comment has been minimized.

@past

past Oct 1, 2014

Nit: extraneous whitespace in the beginning of the line.

@past
Copy link

@past past commented Oct 1, 2014

LGTM.

@fitzgen fitzgen force-pushed the fitzgen:speed-up-parsing branch from f5c16de to 4d06738 Oct 1, 2014
fitzgen added a commit that referenced this pull request Oct 1, 2014
Speed up parsing the mappings.
@fitzgen fitzgen merged commit b407e46 into mozilla:master Oct 1, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.