Speed up parsing #135
Merged
Speed up parsing #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.prototype._parseMappings
|
👍 |
| // Original name. | ||
| temp = base64VLQ.decode(str); | ||
| base64VLQ.decode(str, temp); |
There was a problem hiding this comment.
Nit: extraneous whitespace in the beginning of the line.
|
LGTM. |
fitzgen
force-pushed
the
speed-up-parsing
branch
from
f5c16de
to
4d06738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two changes together shave off about a quarter of time spent parsing the mappings property of a source map.
r? @past