Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Conversation

maurodoglio
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 30, 2017

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   61.49%   61.49%           
=======================================
  Files          21       21           
  Lines        2184     2184           
  Branches       90       90           
=======================================
  Hits         1343     1343           
  Misses        841      841

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df48b74...9d6d61a. Read the comment docs.

@maurodoglio maurodoglio self-assigned this Feb 6, 2017
@maurodoglio maurodoglio requested a review from harterrt February 6, 2017 12:11
--from 20160412 \
--to 20160428
```
Notes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably worth it's own "Update Frequency" section

Schemas and Making Queries
--------------------------

The dataset was built with the long term goal of providing a base for CrashAggregates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives a lot of context. You may want to move this up to the introduction (near line 3).

Notes:

* This dataset will be updated daily via the [telemetry-airflow](https://github.com/mozilla/telemetry-airflow) infrastructure.
* The job DAG runs every day shortly after midnight UTC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "DAG"

@maurodoglio maurodoglio force-pushed the bug-1329233-add-crash-summary-docs branch from 78d104a to 9d6d61a Compare February 15, 2017 12:29
@maurodoglio
Copy link
Contributor Author

This is ready for another look, sorry it took so long.

Copy link
Contributor

@harterrt harterrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@harterrt harterrt merged commit 541bf5c into master Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants