Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Conversation

Uberi
Copy link
Contributor

@Uberi Uberi commented Feb 24, 2016

payloads: List[Map[String, Any]],
root: GenericRecordBuilder,
schema: Schema) {
val values = payloads.map{ case (x) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in #31.

@Uberi
Copy link
Contributor Author

Uberi commented Feb 26, 2016

Changes:

@vitillo
Copy link
Contributor

vitillo commented Feb 26, 2016

Looks good, I am waiting for @mreid-moz to comment on the bug.

@vitillo
Copy link
Contributor

vitillo commented Feb 26, 2016

"The web server that receives Telemetry submissions stores the actual DNT header
value the client sends. This is more comprehensive than the DNT_USAGE
histogram, because it is included for all document types (even ones without
histograms), and that histogram is only being collected for clients who opt in
to extended telemetry. "

@Uberi
Copy link
Contributor Author

Uberi commented Feb 29, 2016

The latest commit adds this field. dnt_header will be either the string 0, 1, or some other unknown value. As a result, it's a string. This field doesn't seem to be present in most telemetry pings from the pipeline.

@vitillo
Copy link
Contributor

vitillo commented Mar 1, 2016

Looks good, thanks.

vitillo added a commit that referenced this pull request Mar 1, 2016
Add additional fields of interest.
@vitillo vitillo merged commit a66e81b into mozilla:master Mar 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants