Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Detect 3rd party cookies and show an error screen #109

Merged
merged 1 commit into from
Aug 2, 2013

Conversation

ozten
Copy link
Contributor

@ozten ozten commented Aug 2, 2013

Sets a cookie during the /provision request.

Tests for cookie during the /signin request. If not present, displays this screen:

Link goes to https://support.mozilla.org/en-US/kb/enable-and-disable-cookies-website-preferences?esab=a&s=3rd+party+cookies&r=2&as=s

@ozten
Copy link
Contributor Author

ozten commented Aug 2, 2013

Force pushed 2 changes - fixed production domain name. Fixed unit test.

@callahad
Copy link

callahad commented Aug 2, 2013

Could this conflict in any way with the change (mozilla/persona#3690) that Shane merged into core to detect and warn about cookie settings?

@ozten
Copy link
Contributor Author

ozten commented Aug 2, 2013

It could "conflict" from a UX perspective. I wasn't able to test end to end.

My hunch is that messaging in the IdP is better even if you are informed twice.

If this patch can ship before the next train, then we could always remove it later.

@ozten
Copy link
Contributor Author

ozten commented Aug 2, 2013

Blocked this morning for dev testing by lack of dev env. Per @karlht and @edmoz we'll merge, release to stage and play with it there.

ozten added a commit that referenced this pull request Aug 2, 2013
Detect 3rd party cookies and show an error screen
@ozten ozten merged commit 8baa716 into master Aug 2, 2013
@mostlygeek
Copy link
Contributor

@ozten isn't merging your own PR sort of like editing your own wikipedia entry? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants