fix: npm release should only include production assets #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpl
changed the title
Rob--W
approved these changes
Dec 19, 2019
| shell.mkdir('-p', destDir, packageDir); | ||
| shell.cp('-rf', config.copy.productionModeAssets.src, packageDir); | ||
| shell.pushd(packageDir); | ||
| shell.exec(`npm pack ${srcDir}`); |
There was a problem hiding this comment.
If srcDir contains a space, then this may fail unexpectedly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does exclude from the released npm package any asset that isn't needed in production (like we did for the sign-addon dependency in mozilla/sign-addon#402).
Besides that, this PR also change the test-functional script to use
npm packto run the production mode functional tests on the same package we would release on npm (without the need to keep a separate list of files to include).