Skip to content

fix: web-ext run: increased debugger connection timeout #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2016
Merged

fix: web-ext run: increased debugger connection timeout #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/cmd/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ export function defaultReloadStrategy(

export function defaultFirefoxClient(
{connectToFirefox=defaultFirefoxConnector,
maxRetries=25, retryInterval=120}: Object = {}) {
// A max of 250 will try connecting for 30 seconds.
maxRetries=250, retryInterval=120}: Object = {}) {
var retries = 0;

function establishConnection() {
Expand Down Expand Up @@ -81,6 +82,7 @@ export function defaultFirefoxClient(
});
}

log.info('Connecting to the remote Firefox debugger');
return establishConnection();
}

Expand Down
2 changes: 1 addition & 1 deletion src/firefox/remote.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function connect(
log.debug(`Connecting to Firefox on port ${port}`);
return connectToFirefox(port)
.then((client) => {
log.info('Connected to the Firefox remote debugger');
log.debug('Connected to the remote Firefox debugger');
return new RemoteFirefox(client);
});
}
Expand Down