Output ZIP files instead of XPI files (fix #325) #328
Conversation
|
I think this should also close #119, as it will package a ZIP file Firefox will load and (presumably) Chrome will load/accept. |
|
Just uploaded the ZIP file
|
|
Cool! I'm taking a look now. One thing we've been doing is making each commit message auto-changelog-ready so could you rename the message to "feat: Output ZIP files instead of XPI files" ? Also, the commit message itself should not mention the github issue (only the pull request should) otherwise every time you rebase and push, it will spam the issue thread (which gets messy). |
|
Ten four, I shall fix these things.
|
tofumatt
force-pushed
the
export-zip-files-instead-of-xpi-325
branch
from
424998c to
07ff822
Compare
|
Fixed both things! |
| let extension = 'zip'; | ||
| let packageName = safeFileName( | ||
| `${manifestData.name}-${manifestData.version}.xpi`); | ||
| `${manifestData.name}-${manifestData.version}.${extension}`); |
There was a problem hiding this comment.
might as well just make this ${manifestData.name}-${manifestData.version}.zip -- no need for a variable
There was a problem hiding this comment.
| assert.equal(filter.wantFile('manifest.json'), false); | ||
| }); | ||
|
|
There was a problem hiding this comment.
heh. I fixed the eslint rule for this in another PR that hasn't landed yet. I was like wut, how did that even get committed? 🎯
There was a problem hiding this comment.
And my editor just deletes trailing whitespace so I didn't even notice I committed it 😄
Should I remove it?
There was a problem hiding this comment.
no, your change is correct. Thanks.
|
|
At first I was wondering if we should make an option to output to Looks good! |
|
oh, heh, I was waiting for fixing up the extraneous variable. All good though, no need for an additional patch. Thanks for getting this in. |
|
Shoot! I made the commit and didn't push it. I am dumb. I'll make another patch, I hate silly extra lines. |
|
ok, if you do, prefix the commit message with |
|
Noted! Thanks :-)
|
Fixes #325
r?
I tested signing and it still a. works with the zip (as expected) and b. sends down an XPI, which is expected behaviour.
Tested
web-ext runand everything still worked as normal too.