-
Notifications
You must be signed in to change notification settings - Fork 362
fix: Fixed Cannot find module '../dist/web-ext'
after installation
#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kumar303 It doesn't fix the issue. I have the same error. |
@addmitriev how did you test if it fixes the issue? :) We would have to publish a new package to test it. |
This was due to `.gitignore` rules that were being added to `.npmignore` and has been broken since the 1.0 release. See mozilla@2f5c4444#diff-a084b794bc0759e7a6b77810e01874f2R10
|
I fixed up the patch with |
r+wc lgtm |
web-ext@2.9.3 -> % web-ext --version Error: Cannot find module '../dist/web-ext' |
@akorchemniy If you are consistently able to reproduce the issue, please open a new ticket and write down the steps you took to trigger the bug. |
Fixes #305
This was due to
.gitignore
rules that were being added to.npmignore
and has been broken (but inconsistently broken) since the 1.0 release. See 2f5c4444#diff-a084b794bc0759e7a6b77810e01874f2R10Info on how npm uses
.gitignore
in place of a missing.npmignore
file: https://github.com/npm/npm/wiki/Files-and-Ignores#details-1