Skip to content

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented Jul 9, 2016

Fixes #305

This was due to .gitignore rules that were being added to .npmignore and has been broken (but inconsistently broken) since the 1.0 release. See 2f5c4444#diff-a084b794bc0759e7a6b77810e01874f2R10

Info on how npm uses .gitignore in place of a missing .npmignore file: https://github.com/npm/npm/wiki/Files-and-Ignores#details-1

@opcode0x
Copy link

@kumar303 It doesn't fix the issue. I have the same error.

@kumar303
Copy link
Contributor Author

@addmitriev how did you test if it fixes the issue? :) We would have to publish a new package to test it.

@muffinresearch muffinresearch self-assigned this Jul 11, 2016
This was due to `.gitignore` rules that were being added to `.npmignore` and has been broken since the 1.0 release. See mozilla@2f5c4444#diff-a084b794bc0759e7a6b77810e01874f2R10
@coveralls
Copy link

coveralls commented Jul 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 62dbc2e on kumar303:npmignore into 0d6abd9 on mozilla:master.

@muffinresearch
Copy link
Contributor

muffinresearch commented Jul 11, 2016

So as mentioned on irc, skip_cleanup: true appears to be missing from the deploy section of the travis.yml. Fixed now

@kumar303
Copy link
Contributor Author

I fixed up the patch with skip_cleanup

@muffinresearch
Copy link
Contributor

r+wc lgtm

@kumar303 kumar303 merged commit 2daa679 into mozilla:master Jul 11, 2016
@kumar303 kumar303 deleted the npmignore branch July 11, 2016 16:23
@akorchemniy
Copy link

web-ext@2.9.3

-> % web-ext --version
internal/modules/cjs/loader.js:611
throw err;
^

Error: Cannot find module '../dist/web-ext'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:609:15)
at Function.Module._load (internal/modules/cjs/loader.js:535:25)
at Module.require (internal/modules/cjs/loader.js:663:17)
at require (internal/modules/cjs/helpers.js:20:18)
at Object. (/home/alexk/.npm-packages/lib/node_modules/web-ext/bin/web-ext:3:14)
at Module._compile (internal/modules/cjs/loader.js:734:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
at Module.load (internal/modules/cjs/loader.js:626:32)
at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
at Function.Module._load (internal/modules/cjs/loader.js:558:3)

@Rob--W
Copy link
Member

Rob--W commented Feb 27, 2019

@akorchemniy dist/web-ext.js is in the package of 2.9.3 : https://registry.npmjs.org/web-ext/-/web-ext-2.9.3.tgz

If you are consistently able to reproduce the issue, please open a new ticket and write down the steps you took to trigger the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants