-
Notifications
You must be signed in to change notification settings - Fork 361
feat: Added lint
command to validate extension source
#372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8d76c8
to
0dfe7a0
Compare
src/cmd/index.js
Outdated
import lint from './lint'; | ||
import sign from './sign'; | ||
export default {build, run, sign}; | ||
export default {build, run, sign, lint}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these are sorted with the exception of the addition.
I wonder if there would be a way to import the yargs config from the linter directly so you can expose the linter as a command and get all the cli features in the linter? Then as the linter changes you should just get the added functionality and it would help avoid any potential breakage should something in the linter change. If this is working for now then it makes sense to not block on it, however, if there's anything that can be done on the linter side to make integration better/easier in future feel free to add issues there. r+wc |
I thought about this too. The upside, as you mentioned, is that new linter program options would magically appear in web-ext. The downside is that it would be hard to know if any of those magic additions would make sense for web-ext or not. For example, it might break web-ext or a new option may be something that web-ext should handle directly (such as how it handles So, yeah, I'm not entirely sure. Copying and pasting the configuration into web-ext makes it very explicit which is nice. If a new option gets added to |
fallout from mozilla#372
Fixes #204