test: introducing flowtype exact object types

package.json

@@ -93,7 +93,7 @@
     "grunt-contrib-watch": "1.0.0",
     "grunt-coveralls": "1.0.1",
     "grunt-eslint": "19.0.0",
-    "grunt-flowbin": "0.0.6",
+    "grunt-flowbin": "rpl/grunt-flowbin#fix/flow-bin-dep",
     "grunt-mocha-test": "0.13.2",
     "grunt-newer": "1.2.0",
     "grunt-webpack": "1.0.15",

src/cmd/build.js

@@ -26,16 +26,14 @@ import type {ExtensionManifest} from '../util/manifest';
 
 // defaultPackageCreator types and implementation.
 
-export type ExtensionBuildResult = {
-  extensionPath: string,
-};
+export type ExtensionBuildResult = {| extensionPath: string |};
 
-export type PackageCreatorParams = {
+export type PackageCreatorParams = {|
   manifestData?: ExtensionManifest,
   sourceDir: string,
   fileFilter: FileFilter,
   artifactsDir: string,
-};
+|};
 
 export type PackageCreatorFn =
     (params: PackageCreatorParams) => Promise<ExtensionBuildResult>;
@@ -72,18 +70,18 @@ async function defaultPackageCreator(
 
 // Build command types and implementation.
 
-export type BuildCmdParams = {
+export type BuildCmdParams = {|
   sourceDir: string,
   artifactsDir: string,
   asNeeded?: boolean,
-};
+|};
 
-export type BuildCmdOptions = {
+export type BuildCmdOptions = {|
   manifestData?: ExtensionManifest,
   fileFilter?: FileFilter,
   onSourceChange?: OnSourceChangeFn,
   packageCreator?: PackageCreatorFn,
-};
+|};
 
 export default async function build(
   {sourceDir, artifactsDir, asNeeded = false}: BuildCmdParams,
@@ -123,9 +121,9 @@ export default async function build(
 
 // FileFilter types and implementation.
 
-export type FileFilterOptions = {
+export type FileFilterOptions = {|
   filesToIgnore?: Array<string>,
-};
+|};
 
 /*
  * Allows or ignores files when creating a ZIP archive.

src/util/manifest.js

@@ -14,6 +14,11 @@ const log = createLogger(__filename);
 export type ExtensionManifest = {
   name: string,
   version: string,
+  applications: {
+    gecko: {
+      id: string
+    }
+  }
 };
 
 export default async function getValidatedManifest(

tests/unit/test-cmd/test.build.js

@@ -43,8 +43,9 @@ describe('build', () => {
         // Make sure a manifest without an ID doesn't throw an error.
         return build({
           sourceDir: fixturePath('minimal-web-ext'),
-          manifestData: manifestWithoutApps,
           artifactsDir: tmpDir.path(),
+        }, {
+          manifestData: manifestWithoutApps,
         });
       }
     );

tests/unit/test-cmd/test.run.js

@@ -1,6 +1,6 @@
 /* @flow */
 import path from 'path';
-import {EventEmitter} from 'events';
+import EventEmitter from 'events';
 import {describe, it} from 'mocha';
 import {assert} from 'chai';
 import sinon from 'sinon';