Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

response: add single cookie response type #102

Merged
merged 1 commit into from
Jun 16, 2017
Merged

response: add single cookie response type #102

merged 1 commit into from
Jun 16, 2017

Conversation

andreastt
Copy link
Contributor

@andreastt andreastt commented Jun 16, 2017

The WebDriver specification mandates that the GetNamedCookie command
should return a cookie serialisation object, and not an array of
cookies.

This patch introduces WebDriverResponse::Cookie and CookieResponse types
to allow WebDriver implementations to return single cookie objects.

Fixes: mozilla/geckodriver#463


This change is Reviewable

@andreastt andreastt requested a review from jgraham June 16, 2017 15:58
The WebDriver specification mandates that the GetNamedCookie command
should return a cookie serialisation object, and not an array of
cookies.

This patch introduces WebDriverResponse::Cookie and CookieResponse types
to allow WebDriver implementations to return single cookie objects.

Fixes: mozilla/geckodriver#463
@jgraham
Copy link
Member

jgraham commented Jun 16, 2017

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jgraham jgraham merged commit 9b49e5a into mozilla:master Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants