Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests when installed using pnpm #127

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 17, 2018

pnpm is the third largest node package manager, which uses symlinks, hardlinks and isolated trees, which prevents packages from using packages which they haven’t declared in their dependencies.

@ExE-Boss ExE-Boss force-pushed the fix/pnpm branch 3 times, most recently from a060245 to 39ae3e8 Compare June 17, 2018 15:23
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Jul 3, 2018

Q: Now that this has been approved, how come it’s still unmerged?

@Rob--W
Copy link
Member

Rob--W commented Jul 4, 2018

@ExE-Boss Tomorrow (Thursday) is the triage meeting where I and @rpl will go through all open PRs.

@rpl rpl merged commit 4712d92 into mozilla:master Jul 4, 2018
@rpl
Copy link
Member

rpl commented Jul 4, 2018

@ExE-Boss @Rob--W actually, this PR looks already good, I didn't notice that Rob didn't merged it yet.
I also tried it locally (just because I never used pnpm before and I wanted to see when the issues were triggered, e.g. with babel-core not explicitly listed in the devDependencies makes "pnpm install" to fail during while it is building the polyfill, and the missing tape makes the integration tests to fails because it doesn't find the tape executable, unsurprisingly).

Thanks @ExE-Boss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants