There is no way to remove closed JedisPool from RedisSenderPoolProvider#standalonePools

[herrlado]

Make sure that:

• You have read the contribution guidelines.
• gelf-logstash-1.14.0
• We reconfigure log4j settings during the runtime with new PropertyConfigurator().doConfigure(reader,
  LogManager.getLoggerRepository());The Commons pools gets closed inbiz.paluch.logging.gelf.intern.sender.GelfREDISSender#closebutRedisSenderPoolProviderstill holds the closedJedisPoolWhen now the log4j properties is reconfigured RedisSenderPoolProvider` delivers a closed JedisPool.

On Closing JedisPool pool, it also must be removed from RedisSenderPoolProvider.

[mp911de]

Thanks for bringing up that issue. The problem is here that RedisSenderPoolProvider is a shared/static holder for various kinds of JedisPool instances. You can have multiple appenders that consume pools. If we close a pool because an appender gets closed, all other active appenders will see a closed JedisPool.

I think we need something like a refcounter to track usage and close the actual pool. Instead of shutting down the Pool, we'd rather decrement the refcounter and if it reaches zero, then we can safely remove the pool from RedisSenderPoolProvider.

[herrlado]

ok, but if the JedisPool gets closed. how can other appenders use the closed one? It is not any more usable, no? I have made a fix as a pull request, to demonstrate the solution. On JedisPool#destroy, it gets removed from the RedisSenderPoolProvider

b9563a2

[mp911de]

Thanks a lot. Reiterating on the issue, we need to track refcount, otherwise, other appenders will see a closed pool. I have a draft locally to fix the issue. Do you mind if we close #247 in favor of my refcnt implementation?

[herrlado]

yes ok in understand. Sure. Thanks

[mp911de]

The fix is now in place. Thanks for your help!