This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Avoid using ThreadMXBean to retrieve the name of the thread #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Dec 2, 2019
| if (threadInfo != null) { | ||
| threadName = threadInfo.getThreadName(); | ||
| } | ||
| Set<Thread> threadSet = Thread.getAllStackTraces().keySet(); |
There was a problem hiding this comment.
getAllStackTraces() is quite expensive. Given that we have a cache in place, we should soften the actual impact.
We should be able to optimize for the default logger arrangement. Typically, log handlers are called on the same thread as the logging happens. Therefore, we should call Thread.currentThread().getId() first to inspect whether we need to obtain all threads or whether we can resolve the thread without further do.
loicmathieu
force-pushed
the
feat/remove-jmx-usage
branch
from
960a2a5
to
cc1a232
Compare
|
Thanks for your contribution. That's merged and polished now. |
mp911de
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
I didn't do any performance test, I would assume that as the name of the threads are cached it's OK to gather them in a slower manner.
I didn't check all the code for possible usage of JMX so this PR will not make the full library GraalVM compliant. Only the JUL Handler (as I use it) works.