Skip to content

Conversation

krishnakumarp
Copy link
Contributor

Implements the ability to set the background-color of the spinner backdrop. Refer #143

@coveralls
Copy link

coveralls commented Nov 26, 2020

Pull Request Test Coverage Report for Build 385724076

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 362358949: 0.0%
Covered Lines: 91
Relevant Lines: 91

💛 - Coveralls

@mpalourdio
Copy link
Owner

mpalourdio commented Nov 26, 2020

Thanks for your contribution, I have just tested and there is a problem now :) When the backdrop is disabled ([backdrop]="false"), there's now a default background color behind the spinner. Will think about it a bit later.

@mpalourdio mpalourdio force-pushed the master branch 2 times, most recently from 65b9a4a to 8772d21 Compare November 26, 2020 17:41
@mpalourdio
Copy link
Owner

I have amended your PR with some commits. Merging now, will release later! thanks a lot for contributing!

@mpalourdio mpalourdio merged commit f3950a0 into mpalourdio:master Nov 26, 2020
@krishnakumarp
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants