Skip to content

Remove unnecessary code #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2018
Merged

Remove unnecessary code #96

merged 1 commit into from
Sep 17, 2018

Conversation

gnom7
Copy link
Contributor

@gnom7 gnom7 commented Sep 17, 2018 •
edited
Loading

  • due to distinctUntilChanged we will get only one show/hide (true/false) event pair in handleSpinnerVisibility method.

@gnom7
Remove unnecessary code
ec6eb39 
* due to `distinctUntilChanged` we will get only one show/hide (true/false) event in `handleSpinnerVisibility` method.
@coveralls
Copy link

coveralls commented Sep 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 528

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 525: 0.0%
Covered Lines: 182
Relevant Lines: 182
💛 - Coveralls

@mpalourdio mpalourdio merged commit 90235fd into mpalourdio:prepare_v310 Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnom7 @coveralls @mpalourdio