Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ElementTree when lxml is not available #13

Merged
merged 1 commit into from
Dec 13, 2013

Conversation

embray
Copy link
Contributor

@embray embray commented Dec 13, 2013

I noticed this trying to get the webbpsfgui working on my Windows machine, where I don't have lxml installed. So it tries falling back to using Python's built-in xml.etree.cElementTree. However there are several places that are using lxml.etree.Element.iterchildren which is not supported in xml.etree so we have to provide an approximate replacement for it.

Once I got this going I was able to get the GUI to at least launch--not sure if there other issues but at least it runs.

…it must be approximated when lxml is not available
mperrin added a commit that referenced this pull request Dec 13, 2013
Fix issue with ElementTree when lxml is not available
@mperrin mperrin merged commit 72fdec3 into mperrin:master Dec 13, 2013
@embray embray deleted the xml-issues branch December 13, 2013 18:58
@embray
Copy link
Contributor Author

embray commented Dec 13, 2013

Thanks--for merging all the PRs. Those were just things I had to do to get it to "work"

@mperrin
Copy link
Owner

mperrin commented Dec 13, 2013

No, more thanks to you for fixing those. Good details to catch to make it more portable, much appreciated.

Sorry for totally failing to get together in person at all this week - my observing schedule put me way more out of commission than I'd expected, not just staying up all night but working on data and software for that project during the afternoons.

Are you in next week? I'll be working Mon-Weds at least, maybe Thurs also.

  • Marshall

On Dec 13, 2013, at 1:59 PM, Erik Bray wrote:

Thanks--for merging all the PRs. Those were just things I had to do to get it to "work"


Reply to this email directly or view it on GitHub.

@embray
Copy link
Contributor Author

embray commented Dec 13, 2013

No problem I figured as much, and things got even more screwed up with the closures. We'll work something out.

mperrin pushed a commit that referenced this pull request May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants