Skip to content

Conversation

yespbs
Copy link
Contributor

@yespbs yespbs commented Aug 30, 2016

Add a middleware generate support to api:generate

@mpociot
Copy link
Owner

mpociot commented Aug 30, 2016

Thank you for the PR. Can we do the same for Dingo?
Also, please update the tests: https://travis-ci.org/mpociot/laravel-apidoc-generator/jobs/156210802#L485-L486

@yespbs
Copy link
Contributor Author

yespbs commented Aug 30, 2016

added text change in testConsoleCommandNeedsAPrefixOrRoute test case

@yespbs
Copy link
Contributor Author

yespbs commented Aug 30, 2016

Hi,

I have not Dingo, I will have to setup and test, this is just a quick fix
for me and since my api routes has no prefix as well list of routes
becoming long, I found a quick fix for Laravel, need to test Dingo
possibilities

Regards,

Priyabrata Sarkar

Web Development & Solutions Consultant.
Proprietor, Sologic Solutions

Company : [http://www.sologicsolutions.com]
Portfolio: [http://www.yespbs.com]
LinkedIn: [http://in.linkedin.com/in/yespbs
http://in.linkedin.com/in/yespbs]

priyabrata.sarkar [Skype]
yespbs@gmail.com [GTalk & AIM]
priyabrata@sologicsolutions.com[Company]

On Tue, Aug 30, 2016 at 6:29 PM, Marcel Pociot notifications@github.com
wrote:

Thank you for the PR. Can we do the same for Dingo?
Also, please update the tests: https://travis-ci.org/mpociot/
laravel-apidoc-generator/jobs/156210802#L485-L486


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#92 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdMVUD1drHow7n2F_0c9eltgy-kRXwtks5qlCk0gaJpZM4JwfDt
.

@codecov-io
Copy link

codecov-io commented Aug 30, 2016

Current coverage is 87.38% (diff: 100%)

Merging #92 into master will increase coverage by 0.18%

@@             master        #92   diff @@
==========================================
  Files             7          7          
  Lines           555        555          
  Methods          42         42          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            484        485     +1   
+ Misses           71         70     -1   
  Partials          0          0          

Powered by Codecov. Last update 8a45951...ab22210

@mpociot
Copy link
Owner

mpociot commented Aug 30, 2016

I just took a look at the Dingo Route class, it also has a middleware method which returns an array:

https://github.com/dingo/api/blob/master/src/Routing/Route.php#L328

So you can implement it the same way as the Laravel process method.

@mpociot
Copy link
Owner

mpociot commented Aug 30, 2016

Awesome! Thank you!

@mpociot mpociot merged commit 976f5ed into mpociot:master Aug 30, 2016
@yespbs
Copy link
Contributor Author

yespbs commented Aug 30, 2016

yes did it, thanks

Regards,

Priyabrata Sarkar

Web Development & Solutions Consultant.
Proprietor, Sologic Solutions

Company : [http://www.sologicsolutions.com]
Portfolio: [http://www.yespbs.com]
LinkedIn: [http://in.linkedin.com/in/yespbs
http://in.linkedin.com/in/yespbs]

priyabrata.sarkar [Skype]
yespbs@gmail.com [GTalk & AIM]
priyabrata@sologicsolutions.com[Company]

On Tue, Aug 30, 2016 at 6:43 PM, Marcel Pociot notifications@github.com
wrote:

Merged #92 #92.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#92 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdMVRoFE8yf0L6vszoQ1MGFMbg850zSks5qlCxhgaJpZM4JwfDt
.

@yespbs
Copy link
Contributor Author

yespbs commented Aug 30, 2016

Welcome

Regards,

Priyabrata Sarkar

Web Development & Solutions Consultant.
Proprietor, Sologic Solutions

Company : [http://www.sologicsolutions.com]
Portfolio: [http://www.yespbs.com]
LinkedIn: [http://in.linkedin.com/in/yespbs
http://in.linkedin.com/in/yespbs]

priyabrata.sarkar [Skype]
yespbs@gmail.com [GTalk & AIM]
priyabrata@sologicsolutions.com[Company]

On Tue, Aug 30, 2016 at 6:42 PM, Marcel Pociot notifications@github.com
wrote:

Awesome! Thank you!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#92 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdMVTgNnBwDo1PVv1pI5Is6YlmNdgB8ks5qlCxagaJpZM4JwfDt
.

@yespbs yespbs deleted the middleware-generate branch August 31, 2016 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants