-
Notifications
You must be signed in to change notification settings - Fork 605
Middleware generate #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the PR. Can we do the same for Dingo? |
added text change in testConsoleCommandNeedsAPrefixOrRoute test case |
Hi, I have not Dingo, I will have to setup and test, this is just a quick fix Regards, Priyabrata Sarkar Web Development & Solutions Consultant. Company : [http://www.sologicsolutions.com] priyabrata.sarkar [Skype] On Tue, Aug 30, 2016 at 6:29 PM, Marcel Pociot notifications@github.com
|
Current coverage is 87.38% (diff: 100%)@@ master #92 diff @@
==========================================
Files 7 7
Lines 555 555
Methods 42 42
Messages 0 0
Branches 0 0
==========================================
+ Hits 484 485 +1
+ Misses 71 70 -1
Partials 0 0
|
I just took a look at the Dingo Route class, it also has a https://github.com/dingo/api/blob/master/src/Routing/Route.php#L328 So you can implement it the same way as the Laravel process method. |
Awesome! Thank you! |
yes did it, thanks Regards, Priyabrata Sarkar Web Development & Solutions Consultant. Company : [http://www.sologicsolutions.com] priyabrata.sarkar [Skype] On Tue, Aug 30, 2016 at 6:43 PM, Marcel Pociot notifications@github.com
|
Welcome Regards, Priyabrata Sarkar Web Development & Solutions Consultant. Company : [http://www.sologicsolutions.com] priyabrata.sarkar [Skype] On Tue, Aug 30, 2016 at 6:42 PM, Marcel Pociot notifications@github.com
|
Add a middleware generate support to api:generate