Develop 0.1.3 first attempt #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbdas This Temporaril address is part of the issue #17 Now the existence of lambda in the code has no effect!
…with * Definitions of the form `lambda *x,**k:x` are valid code but if there is a Error else where The repair module Would try to boot it dummy variable after lambda causing a syntax error
…commas If I remember correctly those additional Special cases were added In order to prevent repairing use cases where * is used as a delimiter separate keyword only arguments from positional ones in function definitions. Nonetheless An additional dummy node does not really hurt, where is it missing prevents us from repairing things like lambda x,*,**k
…en he does at the end of the file first attempt to resolve #19 and more code and cleanups are needed Remember "".isspace()==False
Yet another commit for #19 By using the range version, we get to redo use time complexity from O(nodes) to something closer to O(depth) We also alter the signature of node_from_range to remain backwards compatible With previous versions for obtaining note selection Finally, A small detail to notice Is that the inside function used for single car ets Is slightly changed
Technically it is not considered a statement in the Python AST But for our purposes it can serve such a role Resolves #20
…d_exception_handler Resolved #21 Without this addition, the default behavior of the create fake function is `fake_node.parent = root.parent if parent is None else parent` Causing the exception name to have that ast.Try node as a parent instead of the exception handler
…ompound resolves #22
escaping quotes was the root of #23 They should not be Resolved
…event pylint E1111
…_part The Main news are Argument queries into sub indexing queries were calling line_partial Missing an argument(the code) ( from the age of the dinosaurs 5f6fc5a and More recently d9a049e respectively) . With this fixed,As long as the code tokenize correctly, If there is a syntax error somewhere else in the code that is unrecoverable, those queries can parse only the current logical line instead
…heck for none resolves #26 A check for none was missingAce but more importantly most of the functions expected none values When at the end of file But received EOF token instead
…es of functions While normally, if on an empty line origin is going to bound to the line below, On the boundaries between functions It will bound upwards by design. Unfortunately, These caused An issue because to prevent all my one errors When going upwards When the statements spread over multiple lines, there were checks if we were below its beginning but not thief we were above its ending( because otherwise Origin would normally bound to the linee below!). These commit Add those checks and resolve #28
…gy to be completely crossed out Implements #27 while the same time making reestablishing priority function more readable. At the same time, penalizing now happens Within the result accumulateor
…node like ast.Store these came up during the Re-factoring for issue #19
I must have fixed this blog at least three times and Then stashed the changes
This reverts commit 1973b44.
This reverts commit d576bd4.
…rsor is at the beginning of the line or the whole line is selected resolves #30
relevant to their factoring going on due to #19 The loop was not checking if the token produced is None which caused problems when the cursor Was at the beginning of the file in an empty line
These issue helps resolve #36 because inside queries needed to run a whole bunch of tie-breaking runs on smaller collections of data and the overhead of recomputing the LCA tree every time was skyrocketing their response time
This addition was neededSo the queries of the form "inside nth argument" would work properly. In particular, for these type of queries tiebreaking Needs to happen after inversion because we need to pick the closest call that satisfies the nth description with respect to its (local) parent. Otherwise, the result produced would not be even deterministic,as helpful will not be ordered!!!
These left over print statement were causing crashes if x was None, as may be the case for instance in queries of the form "inside 2 argument 1"
…missing nth
for these kind of queries nth decoding Should happen inside the transformation function not inside process_line. These was causing problems, because queries that they don't specify an inside index("inside first argument 1" As opposed to "inside 1 first argument 1") Were not searching All of the arguments of the parent call But only the one with index 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.