-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo is disproportional #10710
Comments
No matter what I try, I can't reproduce this. Even tried changing the code of osc.lua, but no success. |
@christoph-heinrich Thank you very much for your time. Out of curiosity, have you tested using
|
The issue template requires to post a log for a reason. We can't know which options you set, which VO is in use, etc. |
I mentioned in the reproduction steps to "start mpv without any config". So, no option is set, no With all due respect, below is the log - hopefully it will be helpful.
|
It's most likey that the issue doesn't happen for developers of mpv, or else they would have noticed it already. So we need to figure out why it's different on your system. mpv still makes decisions depending on system values, and sometimes the system is configured in a non standard way, or mpv makes a wrong decision in some circumstances. A log usually helps greatly with narrow down or identifying where the issue comes from. |
Looks like my libass is too old for that commit to make a difference. I have the latest release version, but you're on the latest master, so it might be a bug in libass. It could also be that they fixed a bug in libass since the last release, because I was a confused about the way it handles resolutions that differ in aspect ratio to the real resolution and one could certainly argue that the new behavior is actually correct. You could bisect the libass commits since the 0.16.0 release and see which one introduced that problem for you. That would be a great help in finding out if that change in behavior was intentional from them or not. libass/libass@334e556 introduced the unicode wrap feature that is activated in 9e3ec04 which breaks things for you. Edit: I suspect this has something to do with it libass/libass#645, but I haven't had a closer look yet.
|
Bisected and confirmed this changed in libass/libass@f08f8ea; nothing to do with Unicode wrap. |
Ok, that is part of the PR mentioned above. So that was an intentional change and requires changes to osc.lua. |
Important Information
20220925-git-56e24d5
, and has existed ever since. Current latest is20221002-git-2207236
Reproduction steps
Start mpv without any config.
Expected behavior
The center logo should be proportional, regardless of the windows size. See the screenshot taken from
20220918-git-ba81e4e
.Actual behavior
The center logo is disproportional - see below. And it will change according to the windows size. For example, if I press
f
and go into the full-screen mode (16:9), the logo is proportional again.Log file
N/A
Sample files
N/A
The text was updated successfully, but these errors were encountered: