-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDL error when trying to play MP4 DASH videos from YouTube with yt-dlp #11392
Comments
This happens for me, too (using mpv 0.35.0 though), although in my case, when playing a video with both video and audio, the video plays but not the audio. My own log, using the same command as the creator of the issue, is at mpv-log.txt. (Since I'm only asking for audio in this case, it exits immediately rather than trying to play any video. I've removed my IP as well, though in a different manner, by replacing it with This specifically occurs for me when using a version of yt-dlp at or after commit yt-dlp/yt-dlp@5038f6d7. Using a version of yt-dlp before that commit is fine. It's worth noting that a similar error was reported in November 2022 in #10873, although that was the reverse situation - the audio played, but not the video - and it was a slightly different error (although still involving EDL). |
Having the same issue
log file
|
Same issue here, noticed it first with youtube videos having no audio but video working.
log file
|
I've looked into this only a little bit so far, but as far as I can tell I happens because of this change in yt-dlp, and the following diff "fixes" it. diff --git a/player/lua/ytdl_hook.lua b/player/lua/ytdl_hook.lua
index f40579ad36..3ce9ff9c77 100644
--- a/player/lua/ytdl_hook.lua
+++ b/player/lua/ytdl_hook.lua
@@ -448,7 +448,7 @@ local function formats_to_edl(json, formats, use_all_formats)
end
end
- local url = edl_track or track.url
+ local url = track.url
local hdr = {"!new_stream", "!no_clip", "!no_chapters"}
local skip = #tracks == 0
local params = "" FYI the latest released version of yt-dlp (2023.02.17) does not have that problem. |
Yes, yt-dlp commits were to mitigate some wide-spread, severe throttling from YT side that started happening about a week ago I guess. Your patch seems to work fine(?) as far as I can test, but Crazy that all it took was such a simple change. I was expecting, at least, the edl demuxer C needed to be adapted as well, lmao. |
Same-ish issue here.
because some videos load only the video track without audio and output that error only once (instead of two times as usual) this issue may or may not also be related: yt-dlp/yt-dlp#5592 |
This is exactly what happened and the patch to fix that also broke mpv playback on videos streamed from Youtube with the patched yt-dlp. |
I dont know if I’m doing things wrong, but I tried to copy the patched |
I've answered Trit34's question in the PR, but for anyone else trying the same thing, you also have to use |
but why
|
@candrapersada because your garbage ass OS is blocking the execution of ytdl-patched-red.exe thinking it's malware. Double-click it and you'll likely see Wangblows Defiler pop up. |
use double slash for the path |
|
Co-authored-by: Sandro <sandro.jaeckel@gmail.com> The ytdl_hook.lua supplied with the latest mpv release is incompatible with the latest yt-dlp release, causing streaming some youtube formats to fail. This applies an already-upstreamed fix. Upstream issue: mpv-player/mpv#11392 Upstream patch: mpv-player/mpv#11398
Why did this get closed? Where is the fix? I am using: And still have this issue: Sometimes video not opening at all, somtimes video stream opens without audio. |
The fix got merged on 04.03.2023 and your build is from 08.02.2023. |
Alright thanks for the info. |
Only fixed with ytdl_hook.lua in [demux] Detected file format: Edit decision list Logs:
|
The external data checker was disabled in commit 3fdef98 because of mpv issue mpv-player/mpv#11392, which was fixed in mpv 0.36.0.
0.35.1
Devuan GNU/Linux 5 (daedalus/ceres) x86_64
Compiled from upstream (latest commit
5b28cef72db3b531680d89c121631c73ae05354f
)Debian testing repository
Reproduction steps
--ytdl-format
parameter such that it opens as anedl://
URI; for instance,ba
, andbv
.Expected behavior
Actual behavior
Log file
mpv -v -v --no-config --ytdl-format=ba https://www.youtube.com/watch?v=dQw4w9WgXcQ
https://0x0.st/Hzm8.txt
Note: I removed the "ip" parameter from the YouTube video URL for privacy. The complete URL, nonetheless, points to a valid media source.
I mentioned it happens with YouTube only because it only happened with that source, I wasn't able to find any other MP4 DASH sources as well, so I can't guarantee that it's a YouTube-only issue.
The text was updated successfully, but these errors were encountered: