-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing playback speeds and seeking during high speeds causes high av desynchronisation and gaps in audio #13613
Comments
Two problems here. One, I did not adjust the pts calculation in |
Could you try the build here? |
Just to be clear, when you say stutter do you mean visually or an audio one? |
It's visual only for me. |
OK, yeah that makes sense. The cost of not immediately adjusting av sync to avoid skipping frames results in some visual stutter on the speed change. I'll see if maybe I can smooth it out over the next few frames to make it more imperceptible. |
Is it possible to just start both the video and audio in sync? I don't understand why av sync is affected by speed or seeking? |
It would be nice if it was that simple. Audio and video can start from different positions including after a seek. When you change speed, you modify both the video and audio timings so you have to make sure the sync is still correct. |
Yea, I figured it had to be more complicated than that. I tried the build and video lags a bit, but audio is continuous now. |
I'll note that |
Ended up being too flawed and caused trouble in other areas. There's other approaches to trying to solve the issue this meant to address in the works that should be better, so let's wait on that. Fixes mpv-player#13613 and fixes mpv-player#13622. This reverts commit e3af545.
Important Information
Provide following Information:
If you're not using git master or the latest release, update.
Releases are listed here: https://github.com/mpv-player/mpv/releases
Reproduction steps
Set the following keybinds in
input.conf
Play a file that has both video and audio. (Behavior does not happen on audio-only files). Use keybinds to increase the speed, then seek backwards and forwards. Repeat increasing the speed until desynchronization warning appears.
Also pay attention to the duration of the gap in the audio, or optionally record the played audio using another software.
Actual behavior
--profile=fast
and/or--hwdec=auto-safe
is addedExpected behavior
In previous versions
Log file
mpv.log
Sample files
Issue applies to any file, but can use this test file with a continuous 1000Hz tone (Volume warning! Loud!): https://github.com/mpv-player/mpv/assets/14833020/4186eb16-98e7-4040-b894-e1368fb49431
The text was updated successfully, but these errors were encountered: