Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch_later: store movie title as a reminder #329

Closed
bugmen0t opened this issue Nov 3, 2013 · 3 comments
Closed

watch_later: store movie title as a reminder #329

bugmen0t opened this issue Nov 3, 2013 · 3 comments

Comments

@bugmen0t
Copy link

bugmen0t commented Nov 3, 2013

Over time while using --save-position-on-quit the user may forget which movies/series she dropped at some point. At that point it may be desired to clean up orphaned state files or look up which files they're for in order to resume.

The following can help such a user:

  • store filename as a commented out string
  • write a special playlist with md5->path mapping
--- mpvcore/player/configfiles.c~
+++ mpvcore/player/configfiles.c
@@ -298,6 +298,7 @@ void mp_write_watch_later_conf(struct MP
     FILE *file = fopen(conffile, "wb");
     if (!file)
         goto exit;
+    fprintf(file, "# %s\n", mpctx->filename);
     fprintf(file, "start=%f\n", pos);
     for (int i = 0; backup_properties[i]; i++) {
         const char *pname = backup_properties[i];
@ghost
Copy link

ghost commented Nov 3, 2013

It's intentionally not done for privacy reasons.

@bugmen0t
Copy link
Author

bugmen0t commented Nov 3, 2013

Lightweight saving state (as mpv does) isn't much different from history, e.g. ~/.bash_history. Can't you just call umask() before writing to the file or even before creating watch_later/ directory?

@ghost
Copy link

ghost commented Nov 13, 2013

Rejected.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant