player: write file name to the watch later config file #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was brought up ealier; but I don't want it for the sake of privacy. That's also one of the reasons why resume filenames uses a hash instead of something readable. |
|
Could it be made optional (and disabled by default) with a command-line option? Can't think of a proper name though... |
|
Maybe, though I don't know if this is really worth adding... |
This simply writes the file name as a comment to the top of the watch later config file. It can be useful to the user for determining whether a watch later config file can be manually removed (e.g. in case the corresponding media file has been deleted) or not.
|
Well, the code change is pretty minimal (incl. the new option, it's like 4 lines of code added), and while not very high, there appears to be some user interest (me and the guy from #329 at least). In any case I updated the PR with the command-line option and related documentation (the name of the option can be improved I guess, and probably the wording in the manpage too). |
|
Well then, ok. Merged. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply writes the file name as a comment to the top of the watch later
config file.
It can be useful to the user for determining whether a watch later config file
can be manually removed (e.g. in case the corresponding media file has been
deleted) or not.