-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpv is not written in Rust #7724
Comments
Can you make a PR to fix this issue? |
should totally be swift instead. |
PR is welcome. |
|
Hey troll, consider doing the same in your own project first. |
While I’m not a mpv maintainer, I believe it is their intention to reduce the amount of undefined behavior in the codebase. C meets those goals nicely. |
Seems like reddit founds this. |
Also to the idiots in the reddit thread: we talked about this on an IRC channel, and Akaricchi opened this issue as a joke. |
I can see this has been unlocked, and rightly so. MPV would benefit from this greatly. We already have support for using Vulkan, thats the first 100% performance increase. With Rust we could get the other 100% and kill memory bugs along the way. Sadly i lack the skills myself but if a maintainer takes up the task and has a patreon i would contribute. 👍 |
since we lack the manpower todo this and there wasn't really any discussion going on here any more, i am closing this. this doesn't mean it's completely off the table but we don't need an open issue for this. |
If someone writing binding for mpv in rust. Let me know. I am re-writing ytui-music |
Important Information
Provide following Information:
Reproduction steps
In the mpv source directory, run
find -name '*.c'
, followed byfind -name '*.rs'
.Expected behavior
The first command (
find -name '*.c'
) should produce no output. The second command (find -name '*.rs'
) should print a list of mpv's Rust source files.Actual behavior
The first command lists an alarming amount of
*.c
files. These are source code written in C, an obsolete and dangerous programming language. The second command produces no output at all, which suggests that mpv is, in fact, not written in Rust. Rust is a modern, safe programming language, featuring fearless abstractions and zero-cost concurrency. It's objectively superior to C and every other language in every way, therefore mpv should be rewritten in Rust as soon as possible.Log file
N/A
Sample files
N/A
The text was updated successfully, but these errors were encountered: