Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv is not written in Rust #7724

Closed
Akaricchi opened this issue May 13, 2020 · 11 comments
Closed

mpv is not written in Rust #7724

Akaricchi opened this issue May 13, 2020 · 11 comments

Comments

@Akaricchi
Copy link
Member

Important Information

Provide following Information:

  • mpv version: latest from git
  • Platform and Version: N/A
  • Source of the mpv binary: N/A

Reproduction steps

In the mpv source directory, run find -name '*.c', followed by find -name '*.rs'.

Expected behavior

The first command (find -name '*.c') should produce no output. The second command (find -name '*.rs') should print a list of mpv's Rust source files.

Actual behavior

The first command lists an alarming amount of *.c files. These are source code written in C, an obsolete and dangerous programming language. The second command produces no output at all, which suggests that mpv is, in fact, not written in Rust. Rust is a modern, safe programming language, featuring fearless abstractions and zero-cost concurrency. It's objectively superior to C and every other language in every way, therefore mpv should be rewritten in Rust as soon as possible.

Log file

N/A

Sample files

N/A

@ghost
Copy link

ghost commented May 13, 2020

Can you make a PR to fix this issue?

@Akemi
Copy link
Member

Akemi commented May 14, 2020

should totally be swift instead.

@nxtreaming
Copy link

PR is welcome.

@lordmauve
Copy link

The first command (find -name '*.c') should produce no output.

find is not a tool the mpv maintainers support. This bug tracker is for issues with mpv. Perhaps you are looking for https://savannah.gnu.org/bugs/?group=findutils ?

@ghost
Copy link

ghost commented May 14, 2020

Hey troll, consider doing the same in your own project first.

@saagarjha
Copy link

While I’m not a mpv maintainer, I believe it is their intention to reduce the amount of undefined behavior in the codebase. C meets those goals nicely.

@ghost
Copy link

ghost commented May 14, 2020

Seems like reddit founds this.

@ghost ghost locked as spam and limited conversation to collaborators May 14, 2020
@ghost
Copy link

ghost commented May 14, 2020

Also to the idiots in the reddit thread: we talked about this on an IRC channel, and Akaricchi opened this issue as a joke.

@ghost ghost unlocked this conversation Jun 3, 2020
@lordkitsuna
Copy link

I can see this has been unlocked, and rightly so. MPV would benefit from this greatly. We already have support for using Vulkan, thats the first 100% performance increase. With Rust we could get the other 100% and kill memory bugs along the way. Sadly i lack the skills myself but if a maintainer takes up the task and has a patreon i would contribute. 👍

@Akemi
Copy link
Member

Akemi commented Apr 29, 2021

since we lack the manpower todo this and there wasn't really any discussion going on here any more, i am closing this. this doesn't mean it's completely off the table but we don't need an open issue for this.

@Akemi Akemi closed this as completed Apr 29, 2021
@sudipghimire533
Copy link

If someone writing binding for mpv in rust. Let me know. I am re-writing ytui-music

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants