ao_oss: return actual OSS playing state #11303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Feb 12, 2023
rozhuk-im
force-pushed
the
oss_play_state
branch
from
1d90965
to
9587a49
Compare
sfan5
reviewed
Feb 15, 2023
rozhuk-im
force-pushed
the
oss_play_state
branch
from
9587a49
to
4989c22
Compare
|
@snakedoctr: does this fix ab-loop for you (or anyone else that can test oss)? |
|
Sorry, @Dudemanguy. For some reason github isn't sending me notifications and I never saw this. Was this commited yet, or do you still need me to test this? If so, what's the best way to do that now that we're so far past when you submitted this. |
|
It's not committed yet. If you could test this PR real quick and see if it fixes your issue, that would be great. |
|
Tested -- works great! |
|
Thanks, I'll pull it in then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for: #10640