add --sub-ass-horizontal-scaling-compat option #12157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used by the next few commits
Also add SD_CTRL_SET_OUT_PARAMS to the sd_ctrl enum. This plumbs a way to get the necessary information about the video output for the next commit.
libass before 0.17.0 didn't scale borders, shadows, font spacing and explicit vector drawing coordinates in the x-axis, which used to be inconsistent with what VSFilter used to do. This behavior was changed to improve compatibility with the expected VSFilter behavior. However this new behavior is problematic in some scenarios, particularly if the video is cropped to have a different aspect ratio at the output than what the script resolution dictates. Subtitles would end up with too-thin or too-thick shadows and borders in the x direction, depending on aspect ratio difference between the script resolution and the output resolution.
We can get the PlayResX from the lavc converted ass header, so use that instead of hardcoding 384. We also now have the output resolution available to us through out_params, so use that instead of using the osd dimensions.
This was referenced Aug 26, 2023
|
Do we need this since we have |
|
I'd still prefer this since mpv can still crop videos by itself without the help of a lua script, but I don't think this will be accepted so I'll just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a crop filter inserted, --sub-ass-horizontal-scaling-compat=no and --sub-ass-horizontal-scaling-compat=yes
See individual commit messages. Also not sold on the option name, please let me know if anyone has better ideas.