Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: add --osd-bar-border-size #12959

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

guidocella
Copy link
Contributor

Closes #1484.

Copy link

github-actions bot commented Nov 24, 2023

Download the artifacts for this pull request:

Windows

options/options.c Outdated Show resolved Hide resolved
@guidocella guidocella force-pushed the osd-bar-border-size branch 2 times, most recently from 19cd728 to 9381d1f Compare November 24, 2023 14:30
Copy link
Member

@Dudemanguy Dudemanguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dudemanguy
Copy link
Member

Needs rebase.

Closes mpv-player#1484. The default size is smaller than the previous
--osd-border-size default value of 3 with the default --osd-bar-h.
@Dudemanguy Dudemanguy merged commit 0c4812a into mpv-player:master Nov 27, 2023
14 checks passed
@Obegg
Copy link

Obegg commented Nov 28, 2023

Great option, love it, the only thing I would change is the default from 1.2 to something less, just something to consider changing.
For me, I find the 1.2 value too BOLD which I interpret as old and poor instead of something "modern".
To be clear - I'm not suggesting changing the entire UI/UX to be modernized, the only thing I'm suggesting is a lower value to this option.

@guidocella guidocella deleted the osd-bar-border-size branch November 28, 2023 07:49
@guidocella
Copy link
Contributor Author

Well I set 0.5 originally but the markers were too hard to see. We could try to make the markers bigger instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osd-border-size conflict
5 participants