-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/mingw: use Ubuntu 24.04 #14169
Merged
Merged
ci/mingw: use Ubuntu 24.04 #14169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper93
force-pushed
the
ubuntu
branch
3 times, most recently
from
May 22, 2024 01:07
94043bc
to
772ba3a
Compare
kasper93
force-pushed
the
ubuntu
branch
3 times, most recently
from
June 3, 2024 17:30
0ceb504
to
f5188eb
Compare
Closed
14 tasks
kasper93
force-pushed
the
ubuntu
branch
3 times, most recently
from
June 6, 2024 21:59
ed87369
to
c8994f0
Compare
Download the artifacts for this pull request: |
na-na-hi
reviewed
Jun 6, 2024
kasper93
force-pushed
the
ubuntu
branch
2 times, most recently
from
June 6, 2024 23:57
f320d87
to
86298e5
Compare
sfan5
reviewed
Jun 7, 2024
sfan5
reviewed
Jun 7, 2024
comparison of unsigned expression in '< 0' is always false
Ubuntu 24.04 linux-azure kernel, used on GHA, is compiled with CONFIG_COMPAT_32BIT_TIME=n. This prevents running any 32-bit binaries through wine, so disable tests when doing i686 build. 32-bit builds are still tested on Windows. See: actions/runner-images#9977
The 32-bit builds were disabled, because some packages started disappearing. MSYS2 is slowly phasing out 32-bit support, but since we still support it we have to test it somehow. Recent brakage with calling convention mismatch would be spotted a lot quicker. So enable it, but with some, not available, packages disabled. This reverts a56d5c7
This effectively bumps minimal MinGW-w64 requirement to v11.0.1. As it is available in the latest Ubuntu LTS. While at it clean installed packages list.
sfan5
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good, please wait for CI to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until it is fixed upstream. actions/runner-images#9977