Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift build fixes #5516

Merged
merged 3 commits into from
Feb 12, 2018
Merged

swift build fixes #5516

merged 3 commits into from
Feb 12, 2018

Commits on Feb 12, 2018

  1. build: fix configure on windows 

    configure failed because of a wrong check. fix the check and also only
check for swift on macOS.
    @Akemi
    Akemi committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    15905ef View commit details
    Browse the repository at this point in the history

  2. build: fix swift detection with python3 

    python3 returns bytes instead of str, unlike python2. explicitly decode
the output.
    @Akemi
    Akemi committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    be3a7da View commit details
    Browse the repository at this point in the history

  3. build: fix swift detection on major swift versions 

    the swift version string on major versions only has two components,
major and minor, the third one is missing.
    @Akemi
    Akemi committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    d1df9e1 View commit details
    Browse the repository at this point in the history